chore(fmt): rustfmt caps.rs + provider.rs to unblock the CI pipeline by graycyrus · Pull Request #5177 · tinyhumansai/openhuman

graycyrus · 2026-07-23T18:45:29Z

Summary

upstream/main head (e780277e7) currently fails Rust Quality (fmt, clippy) on pre-existing rustfmt violations that landed with recent merges:

src/openhuman/tinyflows/caps.rs — from Agent output_parser hard-fails whole workflow runs when the model's text is not valid JSON #5151 (the JSON-fence extraction helper).
src/openhuman/agent/harness/subagent_runner/ops/provider.rs — from the lazy-toolkit resolver (Composio contract-gate never executes in sub-agent path — 'what's my latest email' loops forever (GMAIL_FETCH_EMAILS surfaced 51× never runs) #5119-era).

Why this matters (it's not cosmetic)

In .github/workflows/ci-lite.yml:

rust-core-coverage is gated if: … && needs['rust-quality'].result == 'success' — so when rust-quality fails, coverage + the Rust unit tests SKIP.
PR CI Gate fails any needed job whose result is neither success nor skipped — rust-quality = failure makes the gate fail.

Net effect: every branch cut from current main is blocked from merging and its tests never run. This fixes the root cause once.

Change

rustfmt --edition 2021 on the two offending files. Formatting only — line-wrapping of long generic types / constructor calls. Zero logic change (verify: the diff is pure whitespace/line-breaks).

Submission Checklist

Tests added or updated — N/A: formatting-only, no behavior change
Diff coverage ≥ 80% — N/A: no executable lines changed
Coverage matrix updated — N/A: no feature change
All affected feature IDs listed — N/A
No new external network dependencies introduced
Manual smoke checklist updated — N/A: no runtime surface touched
Linked issue closed via Closes #NNN — N/A: pipeline hygiene, no issue

Impact

Unblocks the CI-lite pipeline (coverage lane + PR CI Gate) for all in-flight PRs. No runtime, API, or behavior change.

Summary by CodeRabbit

Refactor
- Applied internal formatting and type-clarity improvements without changing functionality.
- Preserved existing tool resolution, caching, and JSON extraction behavior.
Tests
- Reformatted test assertions and fixtures without changing test coverage or expected results.

upstream/main head (e780277) fails 'Rust Quality (fmt, clippy)' on pre-existing rustfmt violations landed by recent merges (caps.rs from tinyhumansai#5151's JSON-fence extraction; provider.rs from the lazy-toolkit resolver). Because the CI-lite 'PR CI Gate' needs rust-quality == success, and 'Rust Core Coverage' is gated behind the same, this fmt failure cascades: coverage/tests SKIP and the gate FAILS for every branch cut from current main — the whole merge pipeline is blocked, not just fmt cosmetics. Formatting-only (rustfmt --edition 2021), no logic change.

coderabbitai · 2026-07-23T18:45:56Z

📝 Walkthrough

Walkthrough

The pull request applies formatting-only updates to the lazy toolkit resolver and tinyflow JSON extraction code and tests. Types, cache behavior, parsing logic, test inputs, and assertions remain unchanged.

Changes

Formatting updates

Layer / File(s)	Summary
Provider resolver formatting `src/openhuman/agent/harness/subagent_runner/ops/provider.rs`	Reformats the resolver cache declaration and adds an explicit tool type annotation without changing behavior.
Tinyflow parsing and test formatting `src/openhuman/tinyflows/caps.rs`	Reformats JSON extraction logic and two test expressions while preserving semantics.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

tinyhumansai/openhuman#4433: Related formatting updates in the tinyflows implementation.
tinyhumansai/openhuman#5153: Overlapping JSON-extraction formatting in the same file and functions.

Suggested labels: working

Suggested reviewers: senamakel

Poem

I twitch my nose at tidy code,
Where Rusty lines now neatly flowed.
The tools still cache, the parsers sing,
Tests keep their truth in every thing.
Hop, hop—formatting takes wing!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the rustfmt-only changes to caps.rs and provider.rs and the CI-unblock intent.

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-07-23T18:46:55Z

Greptile Summary

Pure rustfmt --edition 2021 formatting pass on two files that had pre-existing style violations introduced by recent merges (#5151, #5119-era), unblocking the rust-quality CI job and, by extension, the coverage lane and PR CI Gate for all in-flight branches.

provider.rs: Reformats the resolved field's long generic type annotation across three lines and reshapes the Arc::new(ComposioActionTool::new(…)) constructor nesting — no logic change.
caps.rs: Wraps the strip_prefix method chain in extract_fenced_json_block and two test-only string/call sites — no logic change.

Confidence Score: 5/5

Safe to merge — every changed line is a whitespace/line-break reformat with no effect on compiled output.

The diff is entirely produced by rustfmt --edition 2021 with no reordering of arguments, no changed operators, and no modified control flow. Both files compile identically before and after the reformat.

No files require special attention.

Important Files Changed

Filename	Overview
src/openhuman/agent/harness/subagent_runner/ops/provider.rs	Formatting-only: field type annotation and Arc constructor call reformatted by rustfmt; no semantic change.
src/openhuman/tinyflows/caps.rs	Formatting-only: method chain wrap in extract_fenced_json_block and two test-site reformats; no semantic change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR branches cut from main] --> B{rust-quality job}
    B -- "BEFORE this PR\n(rustfmt violations)" --> C[rust-quality: FAILURE]
    C --> D[rust-core-coverage: SKIPPED\ncondition not met]
    C --> E[PR CI Gate: FAILED]
    B -- "AFTER this PR\n(files formatted)" --> F[rust-quality: SUCCESS]
    F --> G[rust-core-coverage: RUNS]
    F --> H[PR CI Gate: PASSES]

_{Reviews (2): Last reviewed commit: "chore(fmt): rustfmt caps.rs + provider.r..." | Re-trigger Greptile}

graycyrus requested a review from a team July 23, 2026 18:45

coderabbitai Bot added the working A PR that is being worked on by the team. label Jul 23, 2026

coderabbitai Bot approved these changes Jul 23, 2026

View reviewed changes

graycyrus marked this pull request as draft July 23, 2026 19:28

graycyrus marked this pull request as ready for review July 23, 2026 19:34

senamakel merged commit d70e206 into tinyhumansai:main Jul 24, 2026
25 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(fmt): rustfmt caps.rs + provider.rs to unblock the CI pipeline#5177

chore(fmt): rustfmt caps.rs + provider.rs to unblock the CI pipeline#5177
senamakel merged 1 commit into
tinyhumansai:mainfrom
graycyrus:chore/rustfmt-preexisting-main

graycyrus commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

graycyrus commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why this matters (it's not cosmetic)

Change

Submission Checklist

Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

graycyrus commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading